Fix support for HHVM #106
Merged
Fix support for HHVM #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the fatal error in HHVM (null pointer reference)
See #101. Turns out fsockopen was overriding this, but we have contextual checking support now, so let's use that.
| @@ -393,6 +393,10 @@ public static function test($capabilities = array()) { | |||
| if (isset( $capabilities['ssl'] ) && $capabilities['ssl']) { | |||
| if (!extension_loaded('openssl') || !function_exists('openssl_x509_parse')) | |||
| return false; | |||
|
|
|||
| // Currently broken, thanks to https://github.com/facebook/hhvm/issues/2156 | |||
| if (strpos(PHP_VERSION, 'hiphop') !== false) | |||
There was a problem hiding this comment.
The supported way to check for hhvm is if(defined('HHVM_VERSION'))
There was a problem hiding this comment.
Aha, thanks. I'll switch to that then.
| @@ -274,7 +275,6 @@ protected function setup_handle($url, $headers, $data, $options) { | |||
|
|
|||
| public function process_response($response, $options) { | |||
| if ($options['blocking'] === false) { | |||
| curl_close($this->fp); | |||
There was a problem hiding this comment.
Could you explain the removal here? My group is using non-blocking mode, and the flow here doesn't really look like there should ever have been a double-close. However, this looks like it will keep curl open a bit longer than necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #93.